Remove duplicate callback, add coupler perf pipeline#4504
Merged
Conversation
nefrathenrici
force-pushed
the
ne/fix
branch
2 times, most recently
from
e777a9b to
cd3262d
Compare
Member
|
It's a bit conerning that this changes MSE for non EDMF runs, as it means a duplicate call of |
Member
|
Oh, it changes the MSE of EDMF single column too. |
szy21
reviewed
May 20, 2026
| exit 1 | ||
| else | ||
| echo "✅ SYPD change ($PERCENT_CHANGE%) is okay (threshold: $MIN_PERCENT_CHANGE%)" | ||
| fi No newline at end of file |
szy21
reviewed
May 20, 2026
| slurm_gpus_per_task: 1 | ||
| slurm_cpus_per_task: 4 | ||
| slurm_ntasks: 1 | ||
| slurm_mem: 16GB No newline at end of file |
szy21
approved these changes
May 20, 2026
Member
szy21
left a comment
szy21
left a comment
There was a problem hiding this comment.
We talked offline and it's possible that calling cache again changes the results because we have some iterations for cloud fraction computation. I think it's fine.
nefrathenrici
force-pushed
the
ne/fix
branch
2 times, most recently
from
4e03916 to
0018e77
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the duplicate
enforce_physical_constraints_callbackcallback, which was duplicated incommon_callbacksanddefault_model_callbacksby PR #4469.To catch future performance regressions, this PR also adds an end-to-end coupler performance pipeline. This pipeline runs the flagship
amip_progedmf_1m_land_he16config on clima and checks that the SYPD has not decreased by more than 1%. This pipeline is adapted from the ClimaCore end to end perf pipeline. It is not designed to block PRs, but to track performance regressions in the coupler. It will run on every merged PR and can be manually triggered by adding [perf] to the commit message. This PR increases the SYPD of the pipeline by ~10%, from 0.22 to 0.24 (job).