WIP: replace with hudaquresh model_storm_module.f90#15
Open
delgadom wants to merge 1 commit intoremove-whitespace-model-storm-modulefrom
Open
WIP: replace with hudaquresh model_storm_module.f90#15delgadom wants to merge 1 commit intoremove-whitespace-model-storm-modulefrom
delgadom wants to merge 1 commit intoremove-whitespace-model-storm-modulefrom
Conversation
Member
|
@delgadom just flagging - do you know if this PR is obsolete now or if we want to keep it open? |
Member
Author
|
oh man - I really don't remember. I think we never got parallel CLE to work, and this was another attempt along those lines... |
Member
|
right on! I'll leave it for now as a WIP and we can come back to it if/when we want! |
bolliger32
changed the title
Member
|
Just flagging that the upstream repo has updated model_storm_module.f90 a few times since this PR. If/when we want to re-try parallel CLE, we should check to see if it's been fixed upstream (in which case we could close this) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just comparing CLE differences between prior version and hudaquresh version
This PR is into a branch with trailing whitespace removed to keep diffs to a minimum. If we merge this in, we should do it into master.