Fix lxml and distutils compatibility for Python 3.13 #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I've fixed the lxml/distutils compatibility issues for Python 3.13 and ensured the CI build passes by resolving the PEP 8 style requirements. Ready for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the installation and runtime errors on Python 3.13 (specifically for Windows users) as reported in #383.
Changes:
lxmlversion gating inrequirements.txt. It now useslxml>=5.0.0for Python 3.12+ to ensure pre-compiled wheels are available, avoiding the need for C++ Build Tools.packagingandsetuptoolstorequirements.txtto provide thedistutilsfunctionality that was removed in Python 3.12.evalai/utils/updates.pyto usepackaging.version.Versioninstead of the deprecateddistutils.version.StrictVersion.Fixes #383