add event plane calibrations for 2018 pbpb data#178
Open
bi-ran wants to merge 1 commit into
Open
Conversation
bi-ran
force-pushed
the
addevtplanecalibration
branch
from
c80d07e to
d19cc2b
Compare
mitaylor
pushed a commit
to mitaylor/cmssw
that referenced
this pull request
Sep 1, 2023
* CalcBendCuts - Uses bend encoding to decode bend * Modified CalcBendCuts to be off by default, changed nzbinsPhiCorr to 1 by default * Added changed in TP LUT and set default nzbinsPhiCorr to 1 * Turned off CalcBendCuts and revised comments * PR Cleanup * More PR cleanup * Address PR comments * code-format
mitaylor
pushed a commit
to mitaylor/cmssw
that referenced
this pull request
Sep 1, 2023
* Changed DR so that tracks are only compared to each other if they're in the same overlapping rinv bin. * Added some comments * Changed parts of the code dealing with overlapbins to make it less complex. * Ran scram b -j 8 code-format and other such commands * Fixed line breaks from scram b -j8 code-format. * Fixed line breaks * Fixed line breaks * Deleted unused variables, made comments describing functions more explicit, and declared several things const to save CPU. * Added values that limit the number of tracks per bin and number of comparisons per bin based on firmware limitations. * Added variables that would allow cutting tracks after a set number of tracks is reached in each bin as well as limiting the number of tracks that are compared in eachbin. * Fixed the formatting of new values in Settings.h and PurgeDuplicate.cc * Fixed the formatting of new values in Settings.h and PurgeDuplicate.cc * Changed the way PurgeDuplicate.cc evaluates seedRank * To help rebase * Atownse2 calc bend cuts (CmsHI#178) * CalcBendCuts - Uses bend encoding to decode bend * Modified CalcBendCuts to be off by default, changed nzbinsPhiCorr to 1 by default * Added changed in TP LUT and set default nzbinsPhiCorr to 1 * Turned off CalcBendCuts and revised comments * PR Cleanup * More PR cleanup * Address PR comments * code-format * Deleted git comments from rebase. * Added comments to better explain functions in Settings.h * Changed a vector size comparison for DR that would keep 1 more track per bin than allowed * Changed DR values to recover performance * Added a DR variable to the maxStep map Co-authored-by: Daniel Ally <d.ally@cern.ch> Co-authored-by: Austin Townsend <atownse2@nd.edu> readd data files as not yet in CMSSW release Create github_CI.yml Readd git CI code after branching from latest CMSSW relese bug fixes dummy tweak Make DR easier to understand update to python3 tweak tweak tweak tweak Switch to D88 geometry updated to geometry D88 migrate to D77 geom Switch to D88 geometry Update to new label names Update to new label names Switch to D88 geometry Allow use of D76 MC tweak Create README.md Update README.md Update README.md Update README.md DUMMY COMMIT BEFORE PR Removed CI and data files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://twiki.cern.ch/twiki/bin/viewauth/CMS/SWGuideHeavyIonFlatEvtPlane#CMSSW_10_3_X_Instructions_2018_P
according to instructions, these calibrations depend on the centrality table and have been added only for data.
the calibrations are currently being carried around as a .db file in the repo, but i was wondering if it's possible to upload them to conddb to be able to track them more reliably? @YeonjuGo
Does the PR pass the test script located at
HeavyIonsAnalysis/JetAnalysis/test/runtest.sh
[X] Yes
[] No
@YeonjuGo @cfmcginn