Conversation
Dimo-2562
requested changes
Mar 27, 2026
Contributor
Dimo-2562
left a comment
Dimo-2562
left a comment
There was a problem hiding this comment.
너무너무 수고 많으셨습니다! 피드백 보시고 반영하면 좋을 거 같은거 반영해주세요
src/test/java/umc/cockple/demo/domain/bookmark/service/BookmarkCommandServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/umc/cockple/demo/domain/bookmark/service/BookmarkQueryServiceTest.java
Show resolved
Hide resolved
src/test/java/umc/cockple/demo/domain/bookmark/service/BookmarkQueryServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/umc/cockple/demo/domain/bookmark/service/BookmarkQueryServiceTest.java
Outdated
Show resolved
Hide resolved
| class Success { | ||
|
|
||
| @Test | ||
| @DisplayName("200 - LATEST 정렬로 찜한 운동을 전체 조회하면 모든 필드를 반환한다") |
Contributor
There was a problem hiding this comment.
이거 bookmark를 하나 더 추가해서 저장한 뒤 정렬이 제대로 됐는지 통합쪽에서 다시 한 번 검사하면 좋겠습니다! 물론 단위 테스트에서 검증을 하긴 했으나 통합에서 한 번 더 검증하는 게 좋을 거 같습니다.
data[0].exerciseId와 data[1].exerciseId의 값을 검증해주시면 좋을듯 합니다! 아래 EARLIEST도 같은 방식으로 부탁드립니다
|
|
||
| @Nested | ||
| @DisplayName("성공 케이스") | ||
| class Success { |
Contributor
There was a problem hiding this comment.
여기서도 북마크를 여러 개 해서 정렬이 제대로 됐는지 다시 한 번 체크해주시면 감사하겠습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ 기능 설명
통합테스트
단위테스트
연결된 issue
연결된 issue를 자동으로 닫기 위해 아래 {이슈넘버}를 입력해주세요.
close #518
🩷 Approve 하기 전 확인해주세요!
✅ 체크리스트