Conversation
kanghana1
approved these changes
Mar 29, 2026
Contributor
kanghana1
left a comment
kanghana1
left a comment
There was a problem hiding this comment.
커밋 수 굉장합니다...... 고생하셨어용
|
|
||
| // when | ||
| Slice<PartyDTO.Response> result = partyQueryService.getRecommendedParties(memberId, false, | ||
| filter, "최신순", pageable); |
Contributor
There was a problem hiding this comment.
필터이름을 String보다는 Enum으로 두는 게 일관성 있을 거 같다는 생각이 갑자기 드네요! 나중에 여유되면 바꿔도 좋을 거 같습니다
Contributor
Author
There was a problem hiding this comment.
예전에 개발할 당시에 세훈님과 컨벤션을 맞추고 프론트 측에서 한국어로 작성할 수 있도록 fromKorean을 적용했던 것 같습니다. 이거는 프론트 측 작업도 필요해서 추후에 변경해보겠습니다!
Dimo-2562
requested changes
Mar 30, 2026
Contributor
Dimo-2562
left a comment
Dimo-2562
left a comment
There was a problem hiding this comment.
전체적으로 import문 한 번만 신경써주시고, MEMBER_NOT_FOUND와 PARTY_NOT_FOUND 실패 예외 또한 검증되면 좋을 거 같습니다! 감사합니다.
| } | ||
|
|
||
| @Nested | ||
| @DisplayName("GET /api/my/parties - 내 모임 조회") |
Contributor
There was a problem hiding this comment.
API - 내 모임 조회
- 성공 - 최신순뿐만 아니라 오래된 순, 운동 많은 순도 성공 테스트에 있으면 좋을거 같습니다.
src/test/java/umc/cockple/demo/domain/party/service/PartyQueryServiceTest.java
Show resolved
Hide resolved
src/test/java/umc/cockple/demo/domain/party/integration/PartyIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/umc/cockple/demo/domain/party/service/PartyCommandServiceTest.java
Show resolved
Hide resolved
src/test/java/umc/cockple/demo/domain/party/service/PartyCommandServiceTest.java
Show resolved
Hide resolved
src/test/java/umc/cockple/demo/domain/party/integration/PartyIntegrationTest.java
Show resolved
Hide resolved
src/test/java/umc/cockple/demo/domain/party/service/PartyQueryServiceTest.java
Show resolved
Hide resolved
src/test/java/umc/cockple/demo/domain/party/service/PartyCommandServiceTest.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ 기능 설명
swagger 테스트 성공 결과 스크린샷 첨부
연결된 issue
연결된 issue를 자동으로 닫기 위해 아래 {이슈넘버}를 입력해주세요.
close #519
🩷 Approve 하기 전 확인해주세요!
✅ 체크리스트