Conversation
Dimo-2562
requested changes
Mar 31, 2026
Contributor
Dimo-2562
left a comment
Dimo-2562
left a comment
There was a problem hiding this comment.
너무 고생하셨습니다! 확인 한 번 부탁드립니다~
src/test/java/umc/cockple/demo/domain/notification/fcm/FcmIntegrationTest.java
Show resolved
Hide resolved
|
|
||
| @Nested | ||
| @DisplayName("createNotification - 알림 생성") | ||
| class CreateNotification { |
Contributor
There was a problem hiding this comment.
단위 테스트 - createNotification
PARTY_DELETE, PARTY_INVITE, EXERCISE_DELETE 이렇게 3개만 검증이 된거 같은데 이 밖에도 분기가 많은거 같습니다. 혹시 나머지를 따로 검증하지 않은 이유가 있을까요??
Contributor
Author
There was a problem hiding this comment.
알림의 내용만 변경될 뿐 코드 흐름자체는 동일하기때문에 모든 분기를 다 작성할 필요는 없다고 생각해서 생략했습니다! 추가하는 게 좋을까요?
src/test/java/umc/cockple/demo/domain/notification/integration/NotificationIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/umc/cockple/demo/domain/notification/fcm/FcmIntegrationTest.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ 기능 설명
연결된 issue
연결된 issue를 자동으로 닫기 위해 아래 {이슈넘버}를 입력해주세요.
close #517
✅ 체크리스트