-
Notifications
You must be signed in to change notification settings - Fork 5
chore: bump instrument-hooks #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump instrument-hooks #64
Conversation
41d5a5d to
ea75ede
Compare
CodSpeed Performance ReportMerging #64 will improve performances by ×2.3Comparing Summary
Benchmarks breakdown
|
CodSpeed WallTime Performance ReportMerging #64 will degrade performances by 13.33%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the instrument-hooks subproject to a newer commit version, moving from commit d094ae4d6aa0be555a1016cfbbea74e34b0ed555 to b3d4b78ef68498d59afd45a9c8b2ef096652f034.
- Updates the subproject commit reference for instrument-hooks
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flamegraphs are still catching up some stuff they should preferably not, maybe we need to actually use markers ?
As it stands, it's not worth it to merge IMO, as it does not really improve flamegraph on its own. Unless it fixes something broken with the latest verison of the runner.
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ea75ede to
12b1252
Compare
Signed-off-by: Guillaume Lagrange <guillaume@glagrange.eu>
12b1252 to
174369c
Compare
No description provided.