Skip to content

Conversation

@pujitakalinadhabhotla
Copy link
Contributor

Description

This PR implements the testimonial carousel component. The carousel is built using React, Tailwind CSS, and shadcn UI primitives, and matches the Figma hi-fi design. It supports dynamic slide data, animated transitions, and responsive layouts across screen sizes.

Changes Made

  • [x ] Frontend changes

  • [x ] Configuration updates

  • Implemented a reusable AutoRotatingTestimonialCarousel component

  • Implemented left/right navigation arrows with disabled state during animation

Testing & Verification

  • [x ] Manual testing completed
  • Rendered carousel using sample slide data in TestimonialTester

Screenshots (if relevant)

Screenshot 2026-01-29 at 6 10 54 PM Screenshot 2026-01-29 at 6 11 06 PM Screenshot 2026-01-29 at 6 11 14 PM

Related Issues

Closes #47

Copy link
Collaborator

@aaronashby aaronashby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 💯

Copy link
Collaborator

@thaninbew thaninbew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Super duper cool!!
Feedback:
Is it possible to overlap the cards to more closely match the Figma design?

Image

Another thing is, on my end I don't see animations. The 7second rotation works great, but I don't see any movement or transitional period, just instantly snaps to the next orientation.

I see the transition logic, but I believe the cause may be that the Card component is defined inside the main carousel component (Line 72 AutoRotatingTestimonialCarousel.tsx), in React this causes the object to deleted and recreated. That's kind of my understanding and I think it has to do with the DOM and since the type of component changes it recreates it rather than updates only the props to allow animation. Lmk if that makes any sense..

Animation logic looks solid, can't wait to see this fully working!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Step 4 Carousel

4 participants