Merged
Conversation
The version of anyio that currently gets pulled in through asyncdbus
is incompatible with trio:
File "/home/jk/devel/mctp/mctp/venv/lib/python3.11/site-packages/anyio/_backends/_trio.py", line 141, in cancel
self.__original.cancel(reason)
File "/home/jk/devel/mctp/mctp/venv/lib/python3.11/site-packages/trio/_core/_ki.py", line 183, in wrapper
return fn(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^
TypeError: CancelScope.cancel() takes 1 positional argument but 2 were given
With the breaking change at
agronholm/anyio@b2c933cd .
Bump trio to 0.31 to support cancel reasons.
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Member
|
Should transitive dependencies like anyio also be added to requirements.txt? |
meson's stdout doesn't capture actual failure reasons, so store the log as well. Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
jk-ozlabs
force-pushed
the
dev/test-fixes
branch
from
50b4b18 to
e9988db
Compare
Member
Author
Ideally we'd just have the direct ones, and pip would have some way to lock the transitive ones. I'm not sure if the latter is possible, so maybe freezing everything would be best. I am unsure how the asyncdbus dependency ended up with a newer anyio package though... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current CI is failing in what looks to be a anyio/trio incompatibility.
Bump trio, and upload meson test logs as an artifact.