mctpd: improve handling for out-of-spec Set Endpoint ID responses#83
Merged
mctpd: improve handling for out-of-spec Set Endpoint ID responses#83
Conversation
We may have endpoints reporting strange EID values in their set endpoint ID response, even when reporting that the assignement was accepted. Particularly, if the EID is in the invalid range, we will still attempt to add neighour and route entries for this invalid EID. We still want to accommodate valid IDs that were not the same as the one assigned, but ensure the EID is valid before processing. Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
jk-ozlabs
force-pushed
the
pr/set-eid-response-handling
branch
from
9b7f022 to
2948041
Compare
amboar
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We may have endpoints reporting strange EID values in their set endpoint ID response, even when reporting that the assignement was accepted. Particularly, if the EID is in the invalid range, we will still attempt to add neighour and route entries for this invalid EID.
We still want to accommodate valid IDs that were not the same as the one assigned, but ensure the EID is valid before processing.