mctpd: add initializer for MCTP control messages#95
Merged
jk-ozlabs merged 1 commit intoCodeConstruct:mainfrom Jul 28, 2025
Merged
mctpd: add initializer for MCTP control messages#95jk-ozlabs merged 1 commit intoCodeConstruct:mainfrom
jk-ozlabs merged 1 commit intoCodeConstruct:mainfrom
Conversation
jk-ozlabs
reviewed
Jul 17, 2025
Member
jk-ozlabs
left a comment
jk-ozlabs
left a comment
There was a problem hiding this comment.
I like the use of the initialiser, but a couple of comments inline.
khangng-ampere
force-pushed
the
khangng/push-ppyqzywsztqo
branch
from
6762bbc to
c992c73
Compare
Currently, RQDI bits initialization is duplicated in every message handler. This commit extracts those common logics into functions in mctp-control-spec.h. Signed-off-by: Khang D Nguyen <khangng@os.amperecomputing.com>
khangng-ampere
force-pushed
the
khangng/push-ppyqzywsztqo
branch
from
c992c73 to
fa8e65d
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, RQDI bits initialization is duplicated in every message handler. This commit extracts those common logics into functions in mctp-control-spec.h.
Those logics are trivial so I picked the API based on what I think should be the most ergonomic to use, i.e arbitrary void* + size_t buffer in parameters, and return void* for casting into each MCTP control type message struct.