Cleanup, File Selector improvements and Import cache use #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses "blender/path" from ProjectSettings, and prevents the path getting overwritten every time the plugin is loaded
The Editor class EditorSceneImporter has a function import_scene_from_other_importer which is documented in the code as a utility for importers (like fbx2gltf) to call other scene importers (like Godot's glTF 2.0 importer). It loads the scene and provides a Node that can be saved to a PackedScene. This avoids the need to manually load the glTF file using ResourceLoader, and lets us use the import cache directly
Searches for .exe in Windows, extensionless files for X11, and .app for OSX
Author
|
I'd also like to say, this plugin is excellent at what it does, kudos for making it! I now have a seamless import flow from Blender to Godot. I would love to have this plugin gets more attention from others :D |
Ensures that two users with different paths won't overwrite the path for each other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup to remove unused code in the importer script and change formatting
The Blender executable path is now taken from the Editor Settings, and updated to fit well with macOS and Linux/BSD by changing the filters used. I've tested it for Linux, macOS and Windows should work but I couldn't test it
The plugin now no longer requires a separate cache directory as it can now store the GLB and convert it to an SCN within
res://.import. This is thanks to an Editor API function that lets an importer call the inbuilt Scene importer directlyThis supersedes #1