refactor(agent): factor CLAUDE.md from 3,291→60 lines with prompts submodule (RFC-001)#9
refactor(agent): factor CLAUDE.md from 3,291→60 lines with prompts submodule (RFC-001)#9CodeMonkeyCybersecurity wants to merge 2 commits intomainfrom
Conversation
…module Replace monolithic 3,291-line CLAUDE.md with a 60-line thin proxy that: - Retains essential commands and hera-specific identity - Delegates governance contracts to @third_party/prompts/ @imports - Adds cybermonkey/prompts as third_party/prompts submodule Closes #7 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f65bab8f4d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,3 @@ | |||
| [submodule "third_party/prompts"] | |||
| path = third_party/prompts | |||
| url = ssh://git@vhost7:9001/cybermonkey/prompts.git | |||
There was a problem hiding this comment.
Use reachable submodule URL for prompts dependency
Pointing the new third_party/prompts submodule at ssh://git@vhost7:9001/... makes fresh checkouts fail outside the internal vhost7 network (repro: git submodule update --init --recursive errors with Could not resolve hostname vhost7), which leaves claude.md's imported governance contracts unavailable. This turns the refactor into a broken default for contributors/CI environments that do not have that private host and SSH setup, so the submodule URL should be changed to an accessible remote (or a mirrored public/relative URL).
Useful? React with 👍 / 👎.
…import - Update third_party/prompts to latest main (refs cybermonkey/prompts#566) - Add @third_party/prompts/ANTI-PATTERNS.md to Governance section in CLAUDE.md - Closes #8 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary
third_party/promptsgit submodule (cybermonkey/prompts)@third_party/prompts/@importreferencesChanges
claude.md.gitmodulesthird_party/promptssubmodulethird_party/promptsssh://git@vhost7:9001/cybermonkey/prompts.gitWhy
Per RFC-001: governance contracts were copy-pasted inline. This converts hera to a thin proxy that
@imports governance from the upstreamcybermonkey/promptssubmodule. Only hera-specific context remains: OAuth2/OIDC security testing scope, commands, and the adversarial approach note.Test plan
npm testpasses (hera unit tests — Vitest)git submodule status third_party/promptsshows current SHA (no+prefix)@third_party/prompts/GOVERNANCE-SUMMARY.md,@third_party/prompts/TESTING-JS.mdcybermonkey/prompts#562; follow-up tracked in hera#8)References
third_party/prompts/docs/rfcs/RFC-001-governance-prompt-architecture.mdcybermonkey/prompts#564🤖 Generated with Claude Code