NW6| Fidaa Bashir| HTML/CSS Module| Form Controls| Week3 #179
Conversation
✅ Deploy Preview for cyf-module-html-css ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Ara225
left a comment
Ara225
left a comment
There was a problem hiding this comment.
Nothing but good and one small copy paste job here :)
Form-Controls/index.html
Outdated
| <div class="form-group"> | ||
| <label for="delivery-date">Delivery Date:</label> | ||
| <input type="date" id="delivery-date" name="delivery-date" required min="<?php echo date('Y-m-d'); ?>" | ||
| max="<?php echo date('Y-m-d', strtotime('+4 weeks')); ?>"> |
There was a problem hiding this comment.
these PHP bits won't work. This is plain HTML, can't use PHP here. You woud have to use JS to achive what you want to do here, but I wouldn't worry about that now
There was a problem hiding this comment.
Thanks Anna. I worked on this with Fikret and we asked Simon on how we can specify a date as they asked us in the task in html and he said we can't do that in html so we searched on it and found that we can use php instead of using JS. Today, Altom and Areeb helped me on how to use html to secify the date by specify the min and max date. You can see the changes :)
|
|
||
| input:focus, | ||
| select:focus, | ||
| button:focus { |
There was a problem hiding this comment.
I like this, consistant focus styles :)
| input[type="text"], | ||
| input[type="email"], | ||
| select, | ||
| input[type="date"] { |
| </body> | ||
|
|
||
| </html> | ||
| </html> |
There was a problem hiding this comment.
all very good semantic HTML here. I like the layout, and the simple, practical design as well
2 participants
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.