docs: strengthen portfolio proof and messaging#6
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a65f773c8d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | Issue workflow mode via `--issue <number>` | `src/GsdOrchestrator/Program.cs` | | ||
| | Triage-only mode via `--issue <number> --triage` | `src/GsdOrchestrator/Program.cs`, `src/GsdOrchestrator.Tests/TriagingStateTests.cs` | | ||
| | PR review mode via `--pr <number>` | `src/GsdOrchestrator/Program.cs`, `src/GsdOrchestrator.Tests/ReviewingStateTests.cs` | | ||
| | Watch mode across configured repos via `--watch` | `src/GsdOrchestrator/Program.cs`, `src/GsdOrchestrator/Workflows/Models/RepoConfigLoader.cs` | |
There was a problem hiding this comment.
Correct the multi-repository watch-mode claim
When GSD_REPOS contains multiple repositories, --watch does not watch across them: Program.cs awaits the indefinitely running RunWatchModeAsync inside the foreach loop, so only the first configured repository is ever polled. Describing this as watch mode "across configured repos" gives users an incorrect expectation and can leave later repositories silently unprocessed.
Useful? React with 👍 / 👎.
| ## Enterprise Proof Points | ||
|
|
||
| - **Durability**: workflow state is checkpointed so interrupted runs can be resumed. | ||
| - **Guardrails**: validation blocks unsafe diffs, merge-conflict surprises, and weak test intent. |
There was a problem hiding this comment.
Avoid claiming that weak test intent blocks validation
For plans requiring tests with no modified or generated test files, ValidatingState records only a Warn result and then transitions to Committing; structurally invalid generated tests are also warnings. Therefore the new claim that validation "blocks ... weak test intent" overstates the implemented guardrail and could cause operators to rely on a safety behavior that is not enforced.
Useful? React with 👍 / 👎.
This reverts commit 6c18a9c.
Summary
Why
These changes harden portfolio positioning and documentation clarity for the orchestrator repo.