-
Notifications
You must be signed in to change notification settings - Fork 0
T1(customer): add domain entities, Gender enum, and ICustomerService interface #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devin-ai-integration
wants to merge
1
commit into
devin/customer-service
Choose a base branch
from
devin/customer-service-t1
base: devin/customer-service
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
18 changes: 18 additions & 0 deletions
18
src/Services/Customer/Customer.Domain/Entities/Customer.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| using Customer.Domain.Enums; | ||
|
|
||
| namespace Customer.Domain.Entities; | ||
|
|
||
| public class Customer | ||
| { | ||
| public int Id { get; set; } | ||
| public required string Name { get; set; } | ||
| public required string Email { get; set; } | ||
| public string? PhoneNumber { get; set; } | ||
| public string? Address { get; set; } | ||
| public string? City { get; set; } | ||
| public Gender Gender { get; set; } | ||
| public string? CreatedBy { get; set; } | ||
| public string? UpdatedBy { get; set; } | ||
| public DateTime CreatedDate { get; set; } | ||
| public DateTime UpdatedDate { get; set; } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| namespace Customer.Domain.Enums; | ||
|
|
||
| public enum Gender | ||
| { | ||
| None = 0, | ||
| Female = 1, | ||
| Male = 2 | ||
| } |
Empty file.
10 changes: 10 additions & 0 deletions
10
src/Services/Customer/Customer.Domain/Interfaces/ICustomerService.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| namespace Customer.Domain.Interfaces; | ||
|
|
||
| public interface ICustomerService | ||
| { | ||
| Task<IEnumerable<Entities.Customer>> GetAllAsync(); | ||
| Task<Entities.Customer?> GetByIdAsync(int id); | ||
| Task<Entities.Customer> CreateAsync(Entities.Customer customer); | ||
| Task UpdateAsync(Entities.Customer customer); | ||
| Task<bool> DeleteAsync(int id); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Class name collides with root namespace, may cause resolution issues downstream
The entity class
Customerlives in namespaceCustomer.Domain.Entities, meaning the fully qualified name isCustomer.Domain.Entities.Customer. The root namespace of the project is alsoCustomer. This name collision is already handled inICustomerService.csvia theEntities.Customerqualifier, but downstream consumers (inCustomer.InfrastructureorCustomer.API) may encounter ambiguity when they try to reference the entity — the compiler could confuse the namespaceCustomerwith the classCustomer. This is a known C# pitfall when a type shares its name with its containing namespace hierarchy. It may requireglobal::qualifiers or aliases in future code.Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acknowledged — the class/namespace collision is a known C# pitfall here. The entity name
Customerfollows the project's domain naming convention. Disambiguation is already applied inICustomerService.csviaEntities.Customer. Downstream consumers inCustomer.InfrastructureandCustomer.APIcan use the sameEntities.Customerqualifier (or ausingalias) if needed.