Protein-specific coordinates based on index groups#666
Conversation
|
A general comment: besides making those functions more portable there would be major advantages in making all CVCs rely on atom groups. I think it would be great to just use the three groups While working on #644 I realized that when that is done, CVCs that are based on centers of mass could easily be used any positions, including individual atoms. This would much simplify the data structures of the |
8a50463 to
b07996a
Compare
|
About making the groups groupCA, groupN and groupO generic: I realized that for the alpha CVC, we need to let the user specify several individual ranges of residues to track different alpha-helical segments. This is not compatible with having a single generic name for the index groups. I don't get the comment about CVCs based on COMs being able to use individual atoms - isn't that already the case? |
b07996a to
cb738d8
Compare
cb738d8 to
5aba970
Compare
Note: had to customize the path of dihedralPC file eigenvectors-localmin
5aba970 to
322d9f7
Compare
322d9f7 to
6359abc
Compare
giacomofiorin
left a comment
There was a problem hiding this comment.
Documentation could be improved, but I think the people who would use a template input would far outnumber those who would write it from scratch.
I would merge it in the interest of time but allocate objects using smart pointers at some point.
The goal is to make the alpha_angles CVC (and dihedralPC) available on all back-ends.
TODO: