Skip to content

Fix the NAMD unified reduction#775

Merged
jhenin merged 1 commit intoColvars:masterfrom
HanatoK:fix_namd_reduction
Apr 5, 2025
Merged

Fix the NAMD unified reduction#775
jhenin merged 1 commit intoColvars:masterfrom
HanatoK:fix_namd_reduction

Conversation

@HanatoK
Copy link
Copy Markdown
Member

@HanatoK HanatoK commented Mar 6, 2025

This PR synchronizes the changes introduced in https://gitlab.com/tcbgUIUC/namd/-/merge_requests/392, which depends on https://gitlab.com/tcbgUIUC/namd/-/merge_requests/391.

This PR is marked as draft until the NAMD's patches are merged and Colvars/NAMD is updated.

@HanatoK HanatoK changed the title fix: fix the Colvars reduction Fix the NAMD unified reduction Mar 6, 2025
@jhenin jhenin marked this pull request as ready for review March 18, 2025 14:39
@jhenin jhenin force-pushed the fix_namd_reduction branch from 3f49a3e to 61d01c5 Compare March 18, 2025 14:40
@jhenin jhenin marked this pull request as draft March 18, 2025 14:45
@jhenin
Copy link
Copy Markdown
Member

jhenin commented Mar 18, 2025

(sorry, I thought the NAMD MRs were merged but they are not yet - keeping as draft)

@HanatoK HanatoK marked this pull request as ready for review April 4, 2025 20:59
@HanatoK HanatoK force-pushed the fix_namd_reduction branch from 61d01c5 to 5c0dc55 Compare April 4, 2025 21:12
@HanatoK
Copy link
Copy Markdown
Member Author

HanatoK commented Apr 4, 2025

This has been rebased against the main branch after merging #780 .

@HanatoK HanatoK requested review from giacomofiorin and jhenin April 4, 2025 21:19
Copy link
Copy Markdown
Member

@jhenin jhenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great for us!

@jhenin jhenin merged commit 5cea4f1 into Colvars:master Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants