refactor: completely remove static colvardeps#925
Open
HanatoK wants to merge 11 commits intoColvars:masterfrom
Open
refactor: completely remove static colvardeps#925HanatoK wants to merge 11 commits intoColvars:masterfrom
HanatoK wants to merge 11 commits intoColvars:masterfrom
Conversation
Member
Author
|
I am still not quite sure if destructor of colvarproxy is correct after merging the colvarproxy_* classes. In addition, I don't know why the destrcutor of colvarmodule is designed to call Hi @giacomofiorin! Do you have any ideas about the issues above? |
From the C interface, it is impossible to use the colvarscript class or even get a pointer to the colvarscript object. The example C code in C_test.c shows that only an opaque pointer to colvarproxy is available, so the C functions in extern "C" should get the script object from the opaque pointer instead of expecting the script object being passed as a function argument.
This commit also unifies the way of initializing cvmodule in rotation and rotation_gpu.
HanatoK
force-pushed
the
remove_static_colvardeps
branch
from
6a366d5 to
836f828
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes #924 and completes the removal of static colvarproxy* in #886. Additionally, all
colvarproxy_*classes are merged intocolvarproxy.