231 display lcms data#232
Draft
baolanlequang wants to merge 125 commits into
Draft
Conversation
baolanlequang
force-pushed
the
development
branch
from
168ada3 to
1c80817
Compare
baolanlequang
force-pushed
the
231-display-lcms-data
branch
7 times, most recently
from
6e56218 to
ac30aa4
Compare
baolanlequang
force-pushed
the
231-display-lcms-data
branch
7 times, most recently
from
5d7f862 to
8238de9
Compare
feat: display threshold for multiple spectra
Introduce a new, specific action (resetMultiplicity) to reset the multiplicity state to its initial value, preventing any data from leaking between views. - add resetMultiplicity action and handle it in the corresponding reducer - update layer_init.js to call this new action when the spectrum type changes to a non-NMR layout - lint layer_init.js
Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.7 to 2.0.9. - [Release notes](https://github.com/chimurai/http-proxy-middleware/releases) - [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.9/CHANGELOG.md) - [Commits](chimurai/http-proxy-middleware@v2.0.7...v2.0.9) --- updated-dependencies: - dependency-name: http-proxy-middleware dependency-version: 2.0.9 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.24.8 to 7.27.0. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.27.0/packages/babel-runtime) --- updated-dependencies: - dependency-name: "@babel/runtime" dependency-version: 7.27.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: bump version from 1.3.6 to 1.4.0 * ci: bump node engine from 18 to 22 * move babelrc into package.json add @babel/plugin-transform-runtime add postcss-normalize npx update-browserslist-db@latest upgrade interactive - babel - cypress - type
7 tasks
* feat: auto select Reference from solvent metadata when unset Auto select the Reference in the top bar when a matching solvent is found Use a robust matcher on solvent label and name Keep manual choice if a Reference is already set Build a normalized solvent key from feature metadata Score each candidate and choose the best one Select value is now ref.name
Wrapped the buttons in a element to correctly capture hover events and handle refs, aligning them with other working buttons (like Undo/Redo).
Bumps [node-forge](https://github.com/digitalbazaar/forge) from 1.3.1 to 1.3.2. - [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md) - [Commits](digitalbazaar/forge@v1.3.1...v1.3.2) --- updated-dependencies: - dependency-name: node-forge dependency-version: 1.3.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Replace LICENSE file with MIT license (copyright 2016–2026 Nicole Jung - KIT), update package.json license field, and add MIT badge to README.
MS: hover labels use toolbar decimal setting
MS: show relative intensity with m/z on hover
fix: ms exact mass (M+)
…ugin-transform-modules-systemjs-7.29.4 chore(deps): bump @babel/plugin-transform-modules-systemjs from 7.27.1 to 7.29.4
…-3.1.2 chore(deps): bump fast-uri from 3.0.1 to 3.1.2
chore: Bump version from 1.7.1 to 1.7.2
…-entity building for standalone version
… LCMS multi-entity handling
…e entity information retrieval
Regenerate yarn.lock from merged package.json after resolving lockfile conflict.
+ ignore null children in toolbar collapse count
…with frozen lockfile
This was referenced Jun 23, 2026
Adds src/__tests__/units/pr232_review_blocking.test.tsx, one self-contained suite that reproduces each of the seven blocking issues raised in the review of this PR. Every test asserts the correct (post-fix) behaviour, so it fails on the current branch and turns green once the bug is fixed. - B1 saga_ui.js: peak-add no longer dispatches EDITPEAK.ADD_POSITIVE on non-LCMS layouts (NMR/IR/MS), so peak-add silently no-ops. - B2 integration.js getArea: trapezoidally integrates the cumulative `k` curve instead of returning k(xU)-k(xL); wrong NMR/CV integral. - B3 integration.js getAbsoluteArea: uses cumulative `k` instead of raw `y`. - B4 chem.js Convert2Peak: LC/MS branch discards stored peaks and ignores offset. - B5 multi_focus.js: CV current-density factor double-divides by 100 for mm². - B6 d3_line_rect/index.js: componentDidUpdate dereferences data[0] unguarded. - B7 rect_focus.js drawBar: dereferences tTrEndPts[0] with no length guard. Run: yarn test --watchAll=false src/__tests__/units/pr232_review_blocking.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #254