Skip to content

Conversation

@ozan-cristan
Copy link

Base information

Question | Answer -- | -- Related to a SourceForge thread / Another PR / Combodo ticket? | https://sourceforge.net/p/itop/discussion/922361/thread/0b15547ab3/ Type of change? | Enhancement

Symptom (bug) / Objective (enhancement)

In many enterprise environments, iTop servers do not have direct access to the Internet and must route all outbound HTTP/HTTPS traffic through a corporate proxy.

Currently, the webhook integration module does not provide any way to configure a proxy for outbound requests.
As a result, webhook calls fail in restricted networks, usually with DNS resolution or connection errors, making integrations with external services (Telegram, Slack, APIs, etc.) unusable.

The objective of this enhancement is to allow webhook HTTP requests to be routed through a configurable proxy, making the webhook integration usable in secured and restricted infrastructures.


Reproduction procedure (bug)

(Not applicable, this is an enhancement and not a bug.)


Cause (bug)

(Not applicable, this is an enhancement and not a bug.)


Proposed solution (bug and enhancement)

The solution adds optional HTTP proxy support to the webhook request sender:

  • The proxy configuration is read from the module settings:

    • host (mandatory)

    • user (optional)

    • password (optional)

  • When a proxy is defined, the corresponding CURL options are injected into the request:

    • CURLOPT_PROXY

    • CURLOPT_PROXYTYPE

    • CURLOPT_PROXYUSERPWD (if authentication is configured)

  • When no proxy is defined, the behavior remains unchanged, ensuring full backward compatibility.

This allows webhook integrations to work transparently in environments where Internet access is only available through a proxy.

The change is limited to the webhook integration module and does not impact any other part of iTop.

@Hipska
Copy link
Contributor

Hipska commented Jan 20, 2026

I only see a lot of new files added, no actual changes. Are you sure you committed towards the latest version of the develop branch?

@ozan-cristan
Copy link
Author

You’re right to point that out. The reason you mostly see new files is because the directory
datamodels/2.x/combodo-webhook-integration does not exist in the current develop branch.
Hi Hipska
My changes were originally based on the production branch, where this directory is present. When I rebased onto develop, Git had no common history for that path, so it shows the whole directory as newly added instead of a diff.

So the changes are real, but they appear as new files because the target directory does not yet exist in develop.

@Hipska
Copy link
Contributor

Hipska commented Jan 20, 2026

Well, that repository is located at https://github.com/Combodo/combodo-webhook-integration and not here in iTop base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: First review needed

Development

Successfully merging this pull request may close these issues.

3 participants