Fix the larping bundle by clearing object entity from entity manager#133
Open
rjzondervan wants to merge 4 commits intofeature/oc-bundlefrom
Open
Fix the larping bundle by clearing object entity from entity manager#133rjzondervan wants to merge 4 commits intofeature/oc-bundlefrom
rjzondervan wants to merge 4 commits intofeature/oc-bundlefrom
Conversation
Contributor
|
👋 @rjzondervan
|
rubenvdlinde
approved these changes
Jan 25, 2023
Contributor
rubenvdlinde
left a comment
rubenvdlinde
left a comment
There was a problem hiding this comment.
Like it, the placing makes that it only interacts with test data to start. But the reload right afhter means that an object should always be there.
Can't really think of a situaties where this could go wrong
bbrands02
approved these changes
Jan 25, 2023
Apply fixes from StyleCI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning! Test this very very carefully. It looks good, but clearing the entity manager is something that should be done with extra care.