Open
Conversation
Contributor
|
👋 @bbrands02
|
rjzondervan
requested changes
May 28, 2024
| } | ||
|
|
||
| $responseStatusCode = 400; | ||
| $message = 'ome database connections failed: '.(string) $mongoDBFailCount.' out of '.(string) $mongoDBCount.' connections'; |
Contributor
There was a problem hiding this comment.
In case he combines 2 messages he uses lower s and if this is the start of the message he uses capital S
| $status = 'warn'; | ||
| } | ||
|
|
||
| $responseStatusCode = 400; |
Contributor
There was a problem hiding this comment.
I would throw a 500-range here
| $status = 'fail'; | ||
| $errors = null; | ||
| $outputMessage = $outputMessage ? $outputMessage .= ' and could not fetch error logs: '.$e->getMessage() : $outputMessage = 'Could not fetch error logs: '.$e->getMessage(); | ||
| $responseStatusCode = 400; |
Contributor
There was a problem hiding this comment.
Same here, 400 range sounds like the test does something wrong, instead of that there's an error on the server
WilcoLouwerse
approved these changes
May 28, 2024
| * | ||
| * @param MetricsService $metricsService The metrics service | ||
| * @param ParameterBagInterface $parameters The Parameter bag | ||
| * @param EntityManagerInterface $entityManager The Parameter bag |
Contributor
There was a problem hiding this comment.
docblock description incorrect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.