ClusterExclusion modernization step 1#353
Merged
PDoakORNL merged 2 commits intoCompFUSE:masterfrom Mar 23, 2026
Merged
Conversation
PDoakORNL
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cluster_exclusion ---> ClusterExclusion
remove reference to DcaData from ClusterExclusion pass the object to be operated on as an argument.
This still would be much better if it took arguments that related to its actual data dependence and preserved the encapsulation of dca_data.
But on step at a time.
This class also lacks any unit testing like much of the coarse graining infrastructure.