Migrate line locators to agent-gov-core@v0.1.2#24
Merged
Conversation
Replaces local copies of lineOfJsonKey, lineOfJsonStringValue, lineOfPattern, and escapeRegExp with the shared primitives. The async readJsonObjectWithSource wrapper stays — its ENOENT → empty-object semantics are TaskBound-specific and not duplicated logic. Pure refactor. No kind-string changes, no behavior changes. All 27 existing tests pass against the migrated locators. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure refactor. Replaces local
lineOfJsonKey,lineOfJsonStringValue,lineOfPattern, andescapeRegExpwith the shared primitives fromagent-gov-core@v0.1.2. No kind-string changes, no behavior changes.src/discovery.tsshrinks from 57 → 51 lines, dropping logic now owned by the library. The asyncreadJsonObjectWithSourcewrapper stays — its ENOENT → empty-object semantics are TaskBound-specific.What stays local
JSON.parsedirect (no JSONC comment stripping — deferred; this PR is scope-locked to locator dedup).Action.yml
No changes needed — TaskBound's action already runs
npm ci+npm run buildat action invocation, so the newagent-gov-coreruntime dep resolves automatically.Test plan
npm test— all 27 tests pass🤖 Generated with Claude Code