feat: render history timestamps in familiar's display_tz#122
Closed
CorVous wants to merge 1 commit into
Closed
Conversation
RecentHistoryLayer and RagContextLayer rendered every history timestamp in UTC, so the model saw 'It is now: 2:30PM PDT' in the final reminder while conversation lines still showed UTC — an incoherent sense of time. Thread display_tz into both layers so rendered clocks/date-headers match the reminder's zone.
Owner
Author
|
Folded into #121 — both changes are one feature (display_tz wiring), so they belong in a single PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RecentHistoryLayer and RagContextLayer rendered every history
timestamp in UTC, so the model saw 'It is now: 2:30PM PDT' in the
final reminder while conversation lines still showed UTC — an
incoherent sense of time. Thread display_tz into both layers so
rendered clocks/date-headers match the reminder's zone.