fix(a11y): add role=navigation and aria-label to ActivityBar#40
Open
davidweb3-ctrl wants to merge 1 commit intoCortexLM:mainfrom
Open
fix(a11y): add role=navigation and aria-label to ActivityBar#40davidweb3-ctrl wants to merge 1 commit intoCortexLM:mainfrom
davidweb3-ctrl wants to merge 1 commit intoCortexLM:mainfrom
Conversation
Adds proper ARIA landmark role and accessible name to the ActivityBar container for screen reader users navigating by landmarks. - Added role="navigation" to the aside element - Added aria-label="Primary sidebar" for context Fixes PlatformNetwork/bounty-challenge#27742
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds proper ARIA landmark role and accessible name to the ActivityBar container for screen reader users navigating by landmarks.
Changes
role="navigation"to the<aside>elementaria-label="Primary sidebar"for contextIssue
Fixes PlatformNetwork/bounty-challenge#27742
The Activity bar container previously had no explicit landmark role or accessible name, making it unclear for screen reader users navigating by landmarks.