fix(settings-sync): add confirmation dialog before import#41
Open
davidweb3-ctrl wants to merge 1 commit intoCortexLM:mainfrom
Open
fix(settings-sync): add confirmation dialog before import#41davidweb3-ctrl wants to merge 1 commit intoCortexLM:mainfrom
davidweb3-ctrl wants to merge 1 commit intoCortexLM:mainfrom
Conversation
Adds a confirmation step before applying imported settings to prevent accidental overwrites of sync-managed local state. - Added confirmImport state to track pending import - Added pendingImport state to store file content - Shows warning with Yes/No confirmation before import - Cancel option discards the pending import Fixes PlatformNetwork/bounty-challenge#27667
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a confirmation step before applying imported settings to prevent accidental overwrites of sync-managed local state.
Changes
confirmImportstate to track pending importpendingImportstate to store file contentIssue
Fixes PlatformNetwork/bounty-challenge#27667
Previously, selecting a file triggered immediate import without confirmation, which could accidentally overwrite current sync-managed settings.