ci: add CI workflow (shellcheck + --help smoke)#3
Merged
Conversation
Runs shellcheck and a `--help` smoke test on every shell binary in bin/. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
👋 CorvidAgent is looking into this. |
corvid-agent
approved these changes
May 3, 2026
Contributor
corvid-agent
left a comment
corvid-agent
left a comment
There was a problem hiding this comment.
Clean and well-structured CI. A few observations:
Good:
nullglobhandles emptybin/gracefully- Shebang check avoids running shellcheck on non-shell files
chmod +xin smoke job avoids depending on git filemode
Minor note:
- The shellcheck job accumulates all failures (
fail=1) and reports them together, while the smoke job exits on first failure (|| exit 1). Intentional? If you want to see all broken--helpoutputs in one run, you could use the same accumulator pattern. Not a blocker — just a consistency observation.
LGTM overall. Approving.
The pretty-printing in fledge-github-prs uses `printf "${COLOR}..."` for
escape codes — flagged at info level (SC2059). The variables are
controlled and don't contain `%`, so this is benign style. Skip
info-level so warnings/errors still fail CI.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymlrunning shellcheck and a--helpsmoke test on every shell binary inbin/Test plan
--helpexits 0🤖 Generated with Claude Code