fix(plugins): clean up on build hook failure + spec/doc updates#375
Merged
fix(plugins): clean up on build hook failure + spec/doc updates#375
Conversation
Adds a built-in template that creates a complete fledge plugin repository matching the layout of existing official plugins (roast, etc). Includes plugin.toml, shell command stub, CI workflows, GitHub Pages docs site, README, and LICENSE — all parameterized via Tera prompts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The bin stub is now explicitly a starter placeholder — the comment and README make clear the binary can be replaced with any language. CI smoke test runs --help on all executables regardless of shebang, ShellCheck only runs when bash scripts are present. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When a plugin's build hook failed during install, the cloned plugin directory was left on disk without a registry entry. Subsequent installs saw the directory and rejected with "already installed" while plugins list showed nothing — leaving users stuck without --force. Closes #371 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Plugin spec: separate public API (7 exports) from internal functions (pub(crate)/pub(super)), add visibility column and source file info - Work spec: update deprecated `work pr` message to match actual output which references `fledge github prs create` before `gh pr create` - CLI reference: add `fledge plugins audit` usage examples - CLI reference: add deprecation note for `fledge work pr` - Getting started: expand stub page with links to subsections Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
corvid-agent
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Corvin says...
_
<(^\ .oO(Caw! ^v^)
|/(\
\(\\
" "\\
"Caw! Your code sparkles like a dropped french fry."
CI Summary
| Check | Status |
|---|---|
| Dependency Audit | ✅ Passed |
| Integration (3 OS) | ✅ Passed |
| Lint (fmt + clippy) | ✅ Passed |
| Spec Validation | ✅ Passed |
| Tests (3 OS) | ✅ Passed |
Powered by corvid-pet
Collaborator
Author
|
👋 CorvidAgent is looking into this. |
Collaborator
Author
|
CI all green — thanks Corvin. Ready for human review/merge. |
…ns table The spec checker requires all pub(crate) exports to be listed in the Exported Functions section. Keep the visibility column to distinguish pub from pub(crate), but use a single table so strict mode passes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
❌ Corvin says...
_
<(;\ .oO(oh no...)
|/(\
\(\\
" "\\
"I'm pecking through the errors..."
CI Summary
| Check | Status |
|---|---|
| Dependency Audit | ✅ Passed |
| Integration (3 OS) | ✅ Passed |
| Lint (fmt + clippy) | ✅ Passed |
| Spec Validation | ❌ failure |
| Tests (3 OS) | ✅ Passed |
Powered by corvid-pet
Collaborator
Author
|
👋 CorvidAgent is looking into this. |
Collaborator
Author
|
Spec validation failure was caused by commit Fixed in CI status on the fix commit:
Should be fully green shortly. |
Collaborator
Author
|
👋 CorvidAgent is looking into this. |
Contributor
There was a problem hiding this comment.
✅ Corvin says...
_
<(^\ .oO(Caw! ^v^)
|/(\
\(\\
" "\\
"Looking sharp! Like a beak should be."
CI Summary
| Check | Status |
|---|---|
| Dependency Audit | ✅ Passed |
| Integration (3 OS) | ✅ Passed |
| Lint (fmt + clippy) | ✅ Passed |
| Spec Validation | ✅ Passed |
| Tests (3 OS) | ✅ Passed |
Powered by corvid-pet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fledge plugins install, the cloned directory is now cleaned up instead of being left on disk (fixes Failed plugin build hook leaves stale install state #371)pubexports) from internal functions (pub(crate)/pub(super)), added visibility and source file columnswork prmessage to match actual output referencingfledge github prs createfledge plugins auditusage examples andfledge work prdeprecation noteCloses #371
Test plan
--forcefledge spec check→ 30 specs, 0 errorspubvisibility🤖 Generated with Claude Code