ECC-8464 upgrade to rabbit stasher#17
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Corvina app web template and CLI to use the newer “rabbit-based” stasher configuration, ensuring RabbitMQ is enabled when stasher is selected and updating Helm chart values/templates accordingly.
Changes:
- Upgrade stasher image to
chart-2.1.0and switch stasher Helm template from Redis/config-file based setup to ConfigMap-provided environment variables. - Update CLI prompting/flag handling so enabling stasher enables RabbitMQ by default, and reduce CLI template-generation log noise (Info → Debug in several places).
- Minor YAML indentation fix for minikube values and adjust default CLI log level behavior.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/logging.go | Changes default LOG_LEVEL fallback from WARN to INFO. |
| src/templates/corvina-app-web/helm-charts/values.minikube.yaml | Fixes indentation under stasher.resources.requests. |
| src/templates/corvina-app-web/helm-charts/corvina-app-web/templates/stasher.yaml | Reworks stasher Deployment to use envFrom ConfigMap + RabbitMQ secrets; removes Redis-based init/config. |
| src/templates/corvina-app-web/helm-charts/base.yaml.gotmpl | Bumps stasher image and introduces stasher.envVar.* configuration defaults. |
| src/cmd/webapp.go | Reorders prompts and forces RabbitMQ enabled when stasher is enabled; downgrades several template-walk logs to Debug. |
| main.go | Ensures stasher CLI context is set before deriving rabbit; auto-enables rabbit when stasher is enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.