Skip to content

Add SSH Tunnel check to SSH.pm to prevent users with shell access fro… #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toddr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add SSH Tunnel check to SSH.pm to prevent users with shell access fro… #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions pkg/Cpanel/Security/Advisor/Assessors/SSH.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,28 @@ sub _check_for_ssh_settings {

}

# XXX With default C7 sshd_config, X11Forwarding to yes implies everything else will be yes, so only check one item and then advise to disable everything else

if ( $sshd_config->{'X11Forwarding'} =~ m/yes/i ) {
$self->add_bad_advice(
'key' => 'SSH_tunnels_allowed',
'text' => $self->_lh->maketext('SSH Tunnels are allowed.'),
'suggestion' => $self->_lh->maketext(
'Manually edit /etc/ssh/sshd_config and set "AllowAgentForwarding", "AllowTcpForwarding", and "X11Forwarding" to "no", Then restart SSH in the “[output,url,_1,Restart SSH,_2,_3]” area',
$self->base_path('scripts/ressshd'),
'target',
'_blank'
),
);
}
else {
$self->add_good_advice(
'key' => 'SSH_tunnels_allowed',
'text' => $self->_lh->maketext('SSH tunnels are disabled.'),
);

}

return 1;

}
Expand Down