Provide support for weekdays in timeperiods in PyNag format#14
Open
akimboyko wants to merge 1 commit intoCrapworks:masterfrom
Open
Provide support for weekdays in timeperiods in PyNag format#14akimboyko wants to merge 1 commit intoCrapworks:masterfrom
akimboyko wants to merge 1 commit intoCrapworks:masterfrom
Conversation
akimboyko
commented
Jan 18, 2017
| main_cfg_values = {} | ||
|
|
||
| timeperiod_regex = re.compile( | ||
| '^(monday|tuesday|wednesday|thursday|friday|saturday|sunday)' |
Author
There was a problem hiding this comment.
an initial version provides support for weekdays only
akimboyko
commented
Jan 18, 2017
|
|
||
| def validate(self, endpoint, data={}): | ||
| for attr in data.keys(): | ||
| if endpoint == 'timeperiod': |
Author
There was a problem hiding this comment.
actual solution based on suggestion: use an if statement evereywhere to treat Timeperoids special from pynag issue 243
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Crapworks,
Here is an update for RESTlos
validatefunction to support weekdays in timeperiods in the format supported by 0.9.1.1 version of PyNag.For example:
It is not a real workaround for that as it is not based on PyNag
object_definitions. However, it is good enough for our internal purposes.Other types such as days of generic months, days of specific months, and calendar dates could be supported also if there will be interest by the community