Make command scenarios discover validators#2289
Merged
Merged
Conversation
|
NuGet packages for this PR, e.g. Cratis.Arc: |
0979bb8 to
f03126c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Command scenarios now exercise command validators discovered by Arc, including validators with scenario-provided dependencies and manual overrides.
Added
CommandScenario<TCommand>.scenario.Serviceswithout manually registering the validator.Changed
CommandScenario<TCommand>registers discovered validators in its isolated service provider so scenario validation matches runtime command execution without leaking validators or dependencies across scenarios.CommandResultnow preserves primitive command responses directly instead of passing strings, numbers, and booleans through object deserialization.