Skip indexer properties in command and query validation#2299
Merged
Conversation
The fluent validation filters walked every public property via reflection and called GetValue(instance) with no arguments. For indexer properties (this[...]) that throws "Parameter count mismatch", which surfaced whenever a command or query graph contained a type with an indexer — for example a JsonElement held in an object-typed property. Skip indexer properties so validation traverses the rest of the graph without throwing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
NuGet packages for this PR, e.g. Cratis.Arc: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
Parameter count mismatchwhen the parameter graph contains a type with an indexer (for example aJsonElementheld in anobject-typed property). The recursive fluent validation filters now skip indexer properties.