Skip to content

Revalidate CommandForm currentValues updates#2306

Merged
woksin merged 1 commit into
mainfrom
fix-command-form-current-values-revalidate
Jun 19, 2026
Merged

Revalidate CommandForm currentValues updates#2306
woksin merged 1 commit into
mainfrom
fix-command-form-current-values-revalidate

Conversation

@woksin

@woksin woksin commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Re-run silent command validation after reactive currentValues updates
  • Keep CommandForm isValid accurate for no-field/custom-control dialogs when external state changes
  • Add regressions for invalid-to-valid and valid-to-invalid currentValues changes without fields

Verification

  • yarn test (Source/JavaScript/Arc.React)
  • yarn tsc -p Source/JavaScript/Arc.React/tsconfig.json --noEmit
  • yarn build (Source/JavaScript/Arc.React)

@woksin woksin added the patch label Jun 19, 2026
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

NuGet packages for this PR, e.g. Cratis.Arc:
https://github.com/cratis/arc/packages/1655206?version=20.43.6

@woksin woksin merged commit 40cffdb into main Jun 19, 2026
10 checks passed
@woksin woksin deleted the fix-command-form-current-values-revalidate branch June 19, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@woksin