Fix infinite recursion validating commands with cyclic object graphs#2309
Merged
Conversation
The command FluentValidationFilter walks every public property of every complex command property to run nested validators. Object graphs with back-references — notably System.Text.Json.Nodes.JsonObject, whose child nodes point back to their parent — caused the walk to recurse forever and overflow the stack (HTTP 500). Track visited reference-type instances with a ReferenceEqualityComparer-keyed set so any cycle terminates. Identity keying preserves existing behavior: distinct-but-equal values (e.g. two equal concept values in a list) are each still validated, and unvalidated nested types are still walked to reach deeper validators. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
NuGet packages for this PR, e.g. Cratis.Arc: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
System.Text.Json.Nodes.JsonObject, whose child nodes back-reference their parent) no longer crash command execution with a stack overflow / HTTP 500. Nested validator behavior is unchanged.