Skip to content

Fix update command incorrectly reports "already at latest" after successful update #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
einari merged 2 commits into from
Jun 16, 2026
Merged

Fix update command incorrectly reports "already at latest" after successful update #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d4729b
Initial plan
Copilot Jun 16, 2026
564e844
Fix update command incorrectly reporting "already at latest version"
Copilot Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions Source/Cli/Commands/Version/SelfUpdateCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,21 @@ protected override async Task<int> ExecuteAsync(CommandContext context, SelfUpda
var currentVersion = VersionCommand.GetCliVersion();
var strategy = CliUpdate.DetectStrategy();

// Check for available updates before performing the update
var expectedNewVersion = settings.TargetVersion;
if (string.IsNullOrWhiteSpace(expectedNewVersion))
{
using var updateCheckCts = new CancellationTokenSource(TimeSpan.FromSeconds(10));
try
{
expectedNewVersion = await UpdateChecker.CheckForUpdate(UpdateChecker.CliPackageId, currentVersion, updateCheckCts.Token);
}
catch
{
// If we can't check for updates, proceed anyway - the update tool will handle it
}
}

if (string.Equals(format, OutputFormats.Table, StringComparison.Ordinal))
{
AnsiConsole.MarkupLine($"[bold]Updating Cratis CLI...[/] (current: {currentVersion.EscapeMarkup()})");
Expand Down Expand Up @@ -72,20 +87,24 @@ protected override async Task<int> ExecuteAsync(CommandContext context, SelfUpda
return updateResult.Value;
}

var newVersion = VersionCommand.GetCliVersion();
// Use the expected new version instead of checking the currently running assembly
// The currently running process won't change version until it's restarted
var newVersion = expectedNewVersion ?? currentVersion;
var wasUpdated = !string.IsNullOrWhiteSpace(expectedNewVersion);

if (string.Equals(format, OutputFormats.Json, StringComparison.Ordinal) || string.Equals(format, OutputFormats.JsonCompact, StringComparison.Ordinal))
{
OutputFormatter.WriteObject(format, new
{
PreviousVersion = currentVersion,
CurrentVersion = newVersion,
Updated = currentVersion != newVersion
Updated = wasUpdated
});
}
else if (currentVersion != newVersion)
else if (wasUpdated)
{
AnsiConsole.MarkupLine($"[green]Updated from {currentVersion.EscapeMarkup()} to {newVersion.EscapeMarkup()}[/]");
AnsiConsole.MarkupLine("[dim]The new version will be active when you run 'cratis' again.[/]");
}
else
{
Expand Down
Loading