Processing Tree Implementation and fix for #22#21
Merged
Conversation
starpanda24825
commented
Jun 27, 2026
starpanda24825
commented
Contributor
- Added all new Items into lang files
- Added some placeholder DEPOSIT_DATA and lootTables
- full processing tree with half textures complete
- Structured recipe/texture/model folders
EpicVon2468
requested changes
Jun 28, 2026
EpicVon2468
left a comment
EpicVon2468
left a comment
Contributor
There was a problem hiding this comment.
Why is there a duplicate of every single file from src/main under bin/main ?
Also, you've included some per-user configurations that shouldn't be here.
This needs cleanup before I can properly review.
| "projectName": "create_ore_deposits", | ||
| "mainClass": "net.neoforged.devlaunch.Main", | ||
| "args": [ | ||
| "@C:\\Users\\owner\\Documents\\trae_projects\\Create_Ore_Deposits-1\\build\\moddev\\clientRunProgramArgs.txt" |
Contributor
There was a problem hiding this comment.
This file (.vscode/launch.json) shouldn't be here, it contains per-user configuration with hardcoded paths (such as this).
To remove:
Add .vscode/ to the .gitignore file.
Run git rm .vscode (IIRC)
Commit & push
EpicVon2468
added
enhancement
Contributor
|
Drafting until this is cleaned up (doesn't mean cancelled, just means needs a fix before un-drafting) |
EpicVon2468
changed the title
EpicVon2468
requested changes
Jun 28, 2026
EpicVon2468
left a comment
EpicVon2468
left a comment
Contributor
There was a problem hiding this comment.
Some final cleanup notes
Contributor
|
I'll run a squash merge to prune out the previous erroneous commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.