Drill Tip + Texture + other additions#23
Merged
Conversation
starpanda24825
commented
Jun 30, 2026
Contributor
- Added tiered drill tips (diamond, steel, iron, gold)
- Each drill tip can only mine certain deposit types
- added more textures inclusing two fluid textures
- bottom to top deposit mining using drill pulley
EpicVon2468
requested changes
Jun 30, 2026
EpicVon2468
left a comment
Contributor
There was a problem hiding this comment.
I spy with my little eye, something that beings with Time Of Check, Time Of Use.
| filter: (BlockState) -> Boolean | ||
| ): BlockPos { | ||
| val visited: MutableSet<BlockPos> = mutableSetOf(start) | ||
| private fun buildDepositQueue(startPos: BlockPos) { |
Contributor
There was a problem hiding this comment.
Should probably try to manage resizing & reallocation of sets, lists and deques here, could get resource-expensive fast.
| * on [maxAttempts] and the current extraction interval. | ||
| */ | ||
| fun onBreakTick() { | ||
| if (level?.isClientSide != false) return |
Contributor
There was a problem hiding this comment.
val level = this.level
if (level == null || level.isClientSide) return
Contributor
Author
|
EpicVon2468
requested changes
Jul 3, 2026
EpicVon2468
left a comment
Contributor
There was a problem hiding this comment.
Just the one note :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.