Ore Deposit World Gen Implementation#24
Open
starpanda24825 wants to merge 3 commits into
Open
Conversation
EpicVon2468
requested changes
Jul 8, 2026
EpicVon2468
left a comment
Contributor
There was a problem hiding this comment.
There's too much for me to fully review right now, but just my initial thought is here
| /* | ||
| * Dev-only debug command for verifying that deposit cluster generation is working. | ||
| * | ||
| * This file lives under `src/dev/java`, and `build.gradle` only attaches the `dev` |
Contributor
There was a problem hiding this comment.
This is wonderfully complicated. Just, uh... you only need an if statement for conditional compilation...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added cluster-based ore vein generation using create's layered deposit shapes
netherite reuses diamond's overworld range since this mod is overworld-only (right?)
so not every deposit of the same ore looks identical
Remains: