Skip to content

Conversation

@canac
Copy link
Contributor

@canac canac commented Jan 16, 2026

Description

My understanding is that the current approved MHA amount is the same for both staff so that if one of them passes away their approved MHA doesn't go down. This PR fixes the MHA card to use the approved amount directly instead of adding them together. It also renames some fields for consistency and clarity and fixes a couple localized strings.

@dr-bizz I'd love to get your approval on this PR to make sure that I'm understanding what the HCM API returns correctly.

Testing

  • Go to step 2 of a salary calculation
  • Check that the approved MHA amount is one spouse's approved amount not the sum of both spouses

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
  • I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
  • I have requested a review from another person on the project
  • I have tested my changes in preview or in staging
  • I have cleaned up my commit history

@canac canac requested review from dr-bizz and zweatshirt January 16, 2026 15:05
@canac canac self-assigned this Jan 16, 2026
@canac canac added the Preview Environment Add this label to create an Amplify Preview label Jan 16, 2026
@github-actions
Copy link
Contributor

Preview branch generated at https://mha-card-improvements.d3dytjb8adxkk5.amplifyapp.com

@github-actions
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against c793717

No significant changes found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Preview Environment Add this label to create an Amplify Preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants