feat: move settings.json to .config on unix-like systems#808
Open
lucaengelhard wants to merge 1 commit intoCyberTimon:mainfrom
Open
feat: move settings.json to .config on unix-like systems#808lucaengelhard wants to merge 1 commit intoCyberTimon:mainfrom
lucaengelhard wants to merge 1 commit intoCyberTimon:mainfrom
Conversation
Author
|
Maybe it also would be a good idea to separate things like lastFolderState into a different file, because that isn't relevant for the config and only store real settings data in the config |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the settings are saved next to the program state files on unix-like machines. This PR moves the settings.json file so that it aligns with the .config convention.
Type of Change
Changes Made
Screenshots/Videos
Testing
Test Configuration:
Checklist
Additional Notes
Old settings.json files are automatically moved. Maybe there should be a warning or popup that asks if the user wants the file moved?
Also the folder name is currently hardcoded in. That maybe should be changed?
AI Disclaimer:
Please state the involvement of AI in this PR: