Skip to content

Fix IllegalArgumentException in DamageIndicatedItemFluidContainer.canDrain on empty container #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubensworks merged 2 commits into from
Mar 6, 2026
Merged

Fix IllegalArgumentException in DamageIndicatedItemFluidContainer.canDrain on empty container #219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
750f667
Initial plan
Copilot Mar 6, 2026
d7ab45a
Fix canDrain crash on empty fluid container in DamageIndicatedItemFlu…
Copilot Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...eoforge/src/main/java/org/cyclops/cyclopscore/item/DamageIndicatedItemFluidContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,11 @@ public boolean canDrain(int amount, ItemStack itemStack) {
ItemAccess itemAccess = ItemAccess.forStack(itemStack);
ResourceHandler<FluidResource> fluidHandler = itemAccess.getCapability(Capabilities.Fluid.ITEM);
if (fluidHandler == null) return false;
FluidResource resource = fluidHandler.getResource(0);
// Avoid IllegalArgumentException when the fluid handler has no fluid (empty resource is not allowed in NeoForge extract calls)
if (resource.isEmpty()) return false;
try (var tx = Transaction.openRoot()) {
int simulatedDrain = fluidHandler.extract(fluidHandler.getResource(0), amount, tx);
int simulatedDrain = fluidHandler.extract(resource, amount, tx);
return simulatedDrain == amount;
}
}
Expand Down