Fix race condition in Purifier enchantment blacklist game tests#1175
Fix race condition in Purifier enchantment blacklist game tests#1175rubensworks merged 5 commits intomaster-1.21-ltsfrom
Conversation
Pull Request Test Coverage Report for Build 23374137913Details
💛 - Coveralls |
Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com> Agent-Logs-Url: https://github.com/CyclopsMC/EvilCraft/sessions/d9138adc-a71b-4613-8178-3fbdbb18dfdf
Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com> Agent-Logs-Url: https://github.com/CyclopsMC/EvilCraft/sessions/0bc3a59f-8e45-4d84-a163-a9b6623dc360
Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com> Agent-Logs-Url: https://github.com/CyclopsMC/EvilCraft/sessions/0a51c085-91c0-4ae4-87fd-bca19fae728e
|
@copilot one gametest fails. Please fix, and run it yourself after fixing to ensure it works. |
… own batch Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com> Agent-Logs-Url: https://github.com/CyclopsMC/EvilCraft/sessions/ad67f4c7-d463-4fae-9bec-0a11c2ea7528
Fixed in fb59962. The root cause was The fix adds |
enchantmentIdBlacklistconfig toBlockEntityPurifierConfigusing@ConfigurablePropertyDisenchantPurifyActionto filter blacklisted enchantmentsToolBadEnchantPurifyActionto skip blacklisted cursesGameTestsPurifierwith 3 game tests:testPurifierDisenchant: normal disenchanting workstestPurifierCurseRemoval: normal curse removal workstestPurifierEnchantmentBlacklist: both blacklist scenarios run in isolatedbatch = "purifier_blacklist_0"to avoid concurrent interference with other tests that use the same enchantmentsOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.