Skip to content

fix(test_models.py): évite la mutation de classe m.groups #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miki4iaml wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(test_models.py): évite la mutation de classe m.groups #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5beb705
fix(test_models.py): évite la mutation de classe m.groups
miki4iaml Jun 27, 2026
d1367a5
fix: avoid persistent test model mutation
CyrilJl Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 24 additions & 21 deletions tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
"""
Tests fonctionnels pour les modèles meteofetch.
"""

from gc import collect

import pytest
Expand All @@ -22,7 +26,7 @@

set_test_mode()

MODELS = (
_METEOFRANCE_MODELS = (
Arome001,
Arome0025,
AromeOutreMerAntilles,
Expand All @@ -36,28 +40,27 @@
MFWAM01,
)

# Limiter le nombre de groupes pour tous les modèles
for m in MODELS + (Ifs, Aifs):
m.groups_ = m.groups_[:2]
def _limit_model_groups(monkeypatch, model, n_groups: int = 2):
"""Temporarily limit a model to the first *n_groups* groups for one test."""
monkeypatch.setattr(model, "groups_", model.groups_[:n_groups])
return model

# Liste des configurations GRIB à tester
GRIB_DEFS = ["eccodes", "meteofrance"]


# Fixture pour les modèles
@pytest.fixture(params=MODELS)
def model(request):
return request.param
@pytest.fixture(params=_METEOFRANCE_MODELS, ids=[m.__name__ for m in _METEOFRANCE_MODELS])
def mf_model(request, monkeypatch):
return _limit_model_groups(monkeypatch, request.param)


# Fixture pour les configurations GRIB
@pytest.fixture(params=GRIB_DEFS)
def grib_def(request):
return request.param


def test_aifs():
datasets = Aifs.get_latest_forecast()
def test_aifs(monkeypatch):
model = _limit_model_groups(monkeypatch, Aifs)
datasets = model.get_latest_forecast()
for field in datasets:
print(f"\t{field} - {datasets[field].units}")
ds = datasets[field]
Expand All @@ -68,8 +71,9 @@ def test_aifs():
collect()


def test_ifs():
datasets = Ifs.get_latest_forecast()
def test_ifs(monkeypatch):
model = _limit_model_groups(monkeypatch, Ifs)
datasets = model.get_latest_forecast()
for field in datasets:
print(f"\t{field} - {datasets[field].units}")
ds = datasets[field]
Expand All @@ -80,15 +84,14 @@ def test_ifs():
collect()


def test_meteo_france_models_with_grib_defs(grib_def, model):
# Configurer les définitions GRIB
def test_meteo_france_models_with_grib_defs(grib_def, mf_model):
set_grib_defs(grib_def)
print(f"\nTesting {model.__name__} with {grib_def} definitions")
print(model.availability())
print(f"\nTesting {mf_model.__name__} with {grib_def} definitions")
print(mf_model.availability())

for paquet in model.paquets_:
print(f"\nModel: {model.__name__}, GRIB defs: {grib_def}, Paquet: {paquet}")
datasets = model.get_latest_forecast(paquet=paquet)
for paquet in mf_model.paquets_:
print(f"\nModel: {mf_model.__name__}, GRIB defs: {grib_def}, Paquet: {paquet}")
datasets = mf_model.get_latest_forecast(paquet=paquet)
assert len(datasets) > 0, f"{paquet} : aucun dataset n'a été récupéré."

for field in datasets:
Expand Down
Loading