Refactor plotting and animation logic#15
Merged
Conversation
The files _plot.py and _animate.py were becoming too large and contained mixed logic for classic (scalar) and quiver (vector) plots and animations. This refactoring separates these concerns into two new files: - `mapflow/_classic.py`: Contains `PlotModel` and `Animation` for scalar data. - `mapflow/_quiver.py`: Contains `plot_da_quiver` and a new `QuiverAnimation` class for vector data. The original `_plot.py` and `_animate.py` files have been removed, and the package's `__init__.py` has been updated to expose the same public API. This change improves code organization and makes the library easier to maintain and extend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated the classic and quiver logic from _plot.py and _animate.py into new files: _classic.py and _quiver.py. This improves modularity and maintainability.