fix: prepare v0.2.2-beta keychain hotfix#12
Conversation
Bump the beta preview version to 0.2.2-beta and add release notes for the audit assistant Keychain cleanup fix. Clean stale legacy assistant credentials even when a provider-specific credential already exists, and cover that upgrade path with a regression test.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughv0.2.2-beta updates Xcode/project project version fields, adjusts AuditAssistant credential-migration to remove stale legacy Keychain entries when the normalized target already exists, adds a test validating that behavior, and adds release notes for v0.2.2-beta. Changesv0.2.2-beta Hotfix Release
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@PitcherPlantApp/Sources/PitcherPlantApp/Core/AuditAssistantService.swift`:
- Around line 509-518: The current branch in AuditAssistantService where the
target credential already exists uses try deleteIfPresent(id:
Self.legacyDefaultCredentialID) which can throw and block returning a valid
target; change this to a best-effort cleanup by invoking deleteIfPresent(id:)
inside a do-catch (or using try? ) so any error is swallowed or logged but not
rethrown, then still return false; update the code around
normalizedCredentialID, exists(id:), and deleteIfPresent(id:) to ensure deletion
failures do not propagate.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 25ae83ca-b25f-479d-878d-2d0152c7dc4e
📒 Files selected for processing (5)
PitcherPlantApp/PitcherPlantApp.xcodeproj/project.pbxprojPitcherPlantApp/ReleaseNotes/v0.2.2-beta.mdPitcherPlantApp/Sources/PitcherPlantApp/Core/AuditAssistantService.swiftPitcherPlantApp/Tests/PitcherPlantAppTests/AuditAssistantServiceTests.swiftPitcherPlantApp/project.yml
Summary
Validation
Summary by CodeRabbit