[codex] align main content pages with AppPageShell#9
Merged
Conversation
Route history, report, evidence collection, fingerprint, and whitelist content through the verified AppPageShell scroll-edge container. Remove duplicate page padding and top safe-area handling from those pages so the system titlebar blur behavior follows the same structure as the already working main content screens. Validated with git diff --check, swift test --package-path PitcherPlantApp, xcodebuild test, and build_and_run.sh --verify plus a live page smoke check.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Several primary pages used custom top-level VStack layouts, so they did not participate in the same titlebar scroll-edge behavior as Workbench, New Audit, Workbench Map, and Settings.
Validation