Skip to content

[codex] align main content pages with AppPageShell#9

Merged
D1a0y1bb merged 1 commit into
masterfrom
D1a0y1bb/app-page-shell-pages
May 15, 2026
Merged

[codex] align main content pages with AppPageShell#9
D1a0y1bb merged 1 commit into
masterfrom
D1a0y1bb/app-page-shell-pages

Conversation

@D1a0y1bb
Copy link
Copy Markdown
Owner

What changed

  • Routed history, report center, evidence collection, fingerprint, and whitelist main pages through the verified AppPageShell scroll-edge container.
  • Removed duplicate outer padding and top safe-area handling from those pages so titlebar blur follows the same main-content structure as the already working screens.

Why

Several primary pages used custom top-level VStack layouts, so they did not participate in the same titlebar scroll-edge behavior as Workbench, New Audit, Workbench Map, and Settings.

Validation

  • git diff --check
  • swift test --package-path PitcherPlantApp
  • xcodebuild -project PitcherPlantApp/PitcherPlantApp.xcodeproj -scheme PitcherPlantApp -destination 'platform=macOS' test
  • ./PitcherPlantApp/script/build_and_run.sh --verify
  • Live app smoke check for History, Report Center, All Evidence, Fingerprint Library, and Whitelist pages

Route history, report, evidence collection, fingerprint, and whitelist content through the verified AppPageShell scroll-edge container.

Remove duplicate page padding and top safe-area handling from those pages so the system titlebar blur behavior follows the same structure as the already working main content screens.

Validated with git diff --check, swift test --package-path PitcherPlantApp, xcodebuild test, and build_and_run.sh --verify plus a live page smoke check.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 74bfe29b-5dde-4eef-beee-efe73a792481

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch D1a0y1bb/app-page-shell-pages

Comment @coderabbitai help to get the list of available commands and usage tips.

@D1a0y1bb D1a0y1bb merged commit cc98fed into master May 15, 2026
2 checks passed
@D1a0y1bb D1a0y1bb deleted the D1a0y1bb/app-page-shell-pages branch May 15, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant